This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [ PATCH ] Split out my fold-const.c change and add a test case

From: jimbob at google dot com (Robert Kennedy)
To: "Richard Guenther" <richard dot guenther at gmail dot com>
Cc: "Mark Mitchell" <mark at codesourcery dot com>, "Robert Kennedy" <jimbob at google dot com>, gcc-patches at gcc dot gnu dot org
Date: Tue, 9 Jan 2007 15:48:13 -0800
Subject: Re: [ PATCH ] Split out my fold-const.c change and add a test case
References: <17821.46538.761358.123421@whippen.corp.google.com> <459DDE59.5070701@codesourcery.com> <84fc9c000701050229h5adeb27le8a9d7ee0c2ce6d@mail.gmail.com>
Reply-to: Robert Kennedy <jimbob at google dot com>

> Indeed.  But if this ever happened we'd have an unfolded tree which
> would be another bug.  Of course silent wrong-code in this case is worse
> than an ICE, so I agree with the assert.

Ping.

Perhaps I should have followed up in this thread instead, but
yesterday evening I posted:
  http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00634.html

Is that patch OK now? The assert is added and the test case is there.

Thanks!

	-- Robert

References:
- [ PATCH ] Split out my fold-const.c change and add a test case
  - From: Robert Kennedy
- Re: [ PATCH ] Split out my fold-const.c change and add a test case
  - From: Mark Mitchell
- Re: [ PATCH ] Split out my fold-const.c change and add a test case
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]