This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PR target/30383 (ICE in i386 stringops rewrite)

> 
> On Jan 8, 2007, at 6:41 PM, Jan Hubicka wrote:
> 
> >>>
> >>>! 	  if (code == LABEL_DECL)
> >>>! 	    DECL_ALIGN (t) = BITS_PER_UNIT;
> >>>! 	  else if (code != FUNCTION_DECL)
> >>>
> >>
> >>I think you want bytes not bits here.
> >
> >DECL_ALIGN is bit based:
> >/* Holds the alignment required for the datum, in bits.  */
> 
> Hunh. Brain fart. The real question probably should have been "Are you  
> sure bits_per_unit is right?"

I would say it is (at least in conservative way) - anything smaller than
BITS_PER_UNIT is wrong.  While many architectures mandate greater
alignment I don't see this being interfaced to middle end and I don't
think it really matters.  

Honza
> 
> thanks.
> 
> -eric
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]