This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Document exec and start file search behaviours.


> Carlos O'Donell wrote:
> > This patch updates the documentation to reflect the reality of our
> > exec
> > and start file search behaviours.
> 
>  @item
> -The environment variable @code{GCC_EXEC_PREFIX}, if any.
> +The environment variable @code{GCC_EXEC_PREFIX} or its automatically determined
> +value based on the installed toolchain location.
> 
> Better would be:
> 
>   The environment variable @code{GCC_EXEC_PREFIX} or, if
>   @code{GCC_EXEC_PREFIX} is not set and the compiler has not
>   been installed in the configure-time prefix, the location
>   in which the compiler has actually been installed.

OK.

> +The macro @code{STANDARD_EXEC_PREFIX}, but only if the toolchain is installed
> +in the configured @var{prefix} or this is a native compiler.
> 
> I don't think this is correct.  I don't think native/cross has any
> bearing on this, nor should it, since we're talking about programs the
> compiler runs, not include directories searched.  I think the actual
> correct statement is:
> 
>   The macro @code{STANDARD_EXEC_PREFIX}, if the compiler has been
>   installed in the configure-time prefix.

That is right. I had confused standard_exec_prefix_[12], which *are*
added in a native configuration.

>  @item
> -@file{/usr/lib/gcc/}.
> +The location @file{/usr/lib/gcc/}, but only if this is a native
> compiler.
> 
>  @item
> -The macro @code{MD_EXEC_PREFIX}, if any.
> +The location @file{/usr/libexec/gcc/}, but only if this is a native
> compiler.
> 
> Reverse the order of these two, since we prefer /usr/libexec/gcc.

OK.

I'll rework the patch and check it in. Thanks for the review.


Cheers,
Carlos.
--
Carlos O'Donell
CodeSourcery
carlos@codesourcery.com
(650) 331-3385 x716


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]