This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] PR27698 - Add diagnostic message for invalid names
On Thu, Jan 04, 2007 at 10:13:32PM -0800, Steve Kargl wrote:
>On Thu, Jan 04, 2007 at 11:12:01AM +0100, Bernhard Fischer wrote:
>> On Wed, Jan 03, 2007 at 09:02:50PM -0800, Steve Kargl wrote:
>> >On Wed, Jan 03, 2007 at 05:50:49PM +0100, Bernhard Fischer wrote:
>> >> :ADDPATCH fortran:
>> >>
>> >> According to 3.2.1, a name is
>> >> letter [alphanumeric-character]...
>> >>
>> >> While we did reject invalid names, this PR wanted to have a diagnostic
>> >> message to be printed along rejecting the invalid name.
>> >>
>> >> The attached patch adds this diagnostic message, adds one testcase to
>> >> expect the newly added error message and adjusts testcases that trigger
>> >> the new error.
>> >>
>> >
>> >Why is do_iterator.f90 trigger the patch? Is this a illegal code triggering
>> >the wrong error message?
>>
>> do_iterator.f90 is illegal code for which an error is thrown ("cannot be
>> redefined inside loop beginning at") and then a different matcher
>> (trying 'READ(5,*) I' as a name) is tried.
>
>OK, I understand the change now. Please, commit the patch.
Applied to trunk.
Thanks!