This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: fix warning in libstdc++/src/strstream.cc
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: bje at au1 dot ibm dot com (Ben Elliston)
- Cc: libstdc++ at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org, iant at google dot com
- Date: Thu, 4 Jan 2007 18:45:45 -0500 (EST)
- Subject: Re: PATCH: fix warning in libstdc++/src/strstream.cc
>
> This new warning popped up as a result of some diagnostics work that I
> think I saw mentioned in list traffic. Committed as obvious.
>
> 2007-01-05 Ben Elliston <bje@au.ibm.com>
>
> * src/strstream.cc (strstreambuf::seekoff): Add parentheses around
> truth expression to eliminate a new warning from g++.
>
> Index: src/strstream.cc
> ===================================================================
> --- src/strstream.cc (revision 120450)
> +++ src/strstream.cc (working copy)
> @@ -235,7 +235,7 @@ _GLIBCXX_BEGIN_NAMESPACE(std)
> if ((mode & (ios_base::in | ios_base::out))
> == (ios_base::in | ios_base::out) &&
> (dir == ios_base::beg || dir == ios_base::end))
> - do_get = do_put = true;
> + do_get = (do_put = true);
I don't think we should be warning here at all.
Ian? what do you think?
Thanks,
Andrew Pinski