This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: patches pending review from last year
- From: Roger Sayle <roger at eyesopen dot com>
- To: Manuel Lopez-Ibanez <lopezibanez at gmail dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 2 Jan 2007 14:44:46 -0700 (MST)
- Subject: Re: patches pending review from last year
Hi Manuel,
> On Tue, 2 Jan 2007, Manuel Lopez-Ibanez wrote:
> > [C/C++] PR c/19978 multiple overflow warnings
> > http://gcc.gnu.org/ml/gcc-patches/2006-12/msg00588.html
> > [C] R c/19977 overflow in non-static initializer should not be pedwarn
> > http://gcc.gnu.org/ml/gcc-patches/2006-12/msg01068.html
I'm sorry to comment on these only after they've been approved, but
I've just noticed:
> /* ANSI wants warnings about out-of-range constant initializers. */
> STRIP_TYPE_NOPS (value);
>- constant_expression_warning (value);
>+ if (TREE_STATIC (decl)) constant_expression_warning (value);
This needs to be split over two lines to follow the GNU coding style.
And this
>- overflow_warning (result.value);
>+ if (TREE_OVERFLOW_P (result.value)
>+ && !TREE_OVERFLOW_P (arg1.value) && !TREE_OVERFLOW_P (arg2.value))
>+ overflow_warning (result.value);
could optionally be made prettier by putting each TREE_OVERFLOW_P test
on it's own line. These clean-ups are obvious and shouldn't affect the
approval.
Many thanks again for working on this.
Roger
--