This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: RFC: SMS problem with emit_copy_of_insn_after copying REG_NOTEs

From: "Vladimir Yanovsky" <volodyan at gmail dot com>
To: "Jan Hubicka" <jh at suse dot cz>
Cc: "Jan Hubicka" <hubicka at ucw dot cz>, gcc at gcc dot gnu dot org, "Vladimir Yanovsky" <yanov at il dot ibm dot com>, "Ayal Zaks" <zaks at il dot ibm dot com>, gcc-patches at gcc dot gnu dot org
Date: Sun, 31 Dec 2006 07:15:37 -0500
Subject: Re: RFC: SMS problem with emit_copy_of_insn_after copying REG_NOTEs
References: <48ee23ef0612181248l255833bcjd529c1651aef7a28@mail.gmail.com> <20061218205823.GA2339@atrey.karlin.mff.cuni.cz> <48ee23ef0612190443q59f0937cp4eceeb1c579bb77a@mail.gmail.com> <20061230120026.GA28965@kam.mff.cuni.cz>

Hi,
Sorry for possibly causing confusion. I had tested the patch on my ICE
testcase and bootstrapped for -enable-languages=C, but didn't run the
full bootstrap. Bootstrapping the latest Andrew's patch on ppc-linux
and testing it on SPU.

Vladimir

On 12/30/06, Jan Hubicka <jh@suse.cz> wrote:

Hi,
thanks for testing.  I've bootstrapped/regtested this variant of patch
and comitted it as obvious.

Honza

2006-12-30  Jan Hubicka  <jh@suse.cz>
            Vladimir Yanovsky <volodyan@gmail.com>

        * emit-rt.c (emit_copy_of_insn_after): Fix bug causing exponential
        amount of copies of INSN_NOTEs list.

Index: emit-rtl.c
===================================================================
--- emit-rtl.c  (revision 120274)
+++ emit-rtl.c  (working copy)
@@ -5297,14 +5297,12 @@ emit_copy_of_insn_after (rtx insn, rtx a
       {
        if (GET_CODE (link) == EXPR_LIST)
          REG_NOTES (new)
-           = copy_insn_1 (gen_rtx_EXPR_LIST (REG_NOTE_KIND (link),
-                                             XEXP (link, 0),
-                                             REG_NOTES (new)));
+               = gen_rtx_EXPR_LIST (REG_NOTE_KIND (link),
+                 copy_insn_1 (XEXP (link, 0)),  REG_NOTES (new));
        else
          REG_NOTES (new)
-           = copy_insn_1 (gen_rtx_INSN_LIST (REG_NOTE_KIND (link),
-                                             XEXP (link, 0),
-                                             REG_NOTES (new)));
+              = gen_rtx_INSN_LIST (REG_NOTE_KIND (link),
+                copy_insn_1 (XEXP (link, 0)),  REG_NOTES (new));
       }

/* Fix the libcall sequences. */

References:
- Re: RFC: SMS problem with emit_copy_of_insn_after copying REG_NOTEs
  - From: Jan Hubicka

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]