This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH/testsuite] handle excessively large tests on spu-*-*


On Thu, Dec 21, 2006 at 03:20:21PM +1100, Ben Elliston wrote:
> On Wed, 2006-12-20 at 20:12 -0800, Andrew Pinski wrote:
> 
> > This seems like a better way except for:
> > >         * lib/g++-dg.exp (g++-dg-prune): Likewise.
> >
> >
> > >  proc g++-dg-prune { system text } {
> > > +    if {[string match "spu-*" $system] && \
> > > +           [string match "*exceeds local store range*" $text]} {
> > > +       # The format here is important.  See dg.exp.
> > > +       return "::unsupported::memory full"
> > > +    }
> > >      return [gcc-dg-prune $system $text]
> > >  }
> >
> > This, g++-dg-prune already calls gcc-dg-prune so there is no need to add
> > this.
> 
> Duh :-)  Thanks for catching that.
> 
> > Plus it seems like you also change libstdc++/testsuite/prune.exp to
> > add this.  Or really fix it so it actually calls gcc-dg-prune also.
> 
> Or perhaps g++-dg-prune?
> 
> Cheers, Ben

I'm going on vacation for a couple of weeks, so I'll pre-approve
whatever you and Andrew agree is the appropriate fix here.
(I will catch up on gcc-patches mail before I disappear, though.)

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]