This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New varpool walking API


> Jan,
Hi,
> 
> Just a couple of comments
> Any reason not to use the FOR_EACH_STATIC_VARIABLE macro here?
> Likewise here?

The first loop walks just till first static variable with initializer,
it can be writed with FOR_EACH, but it is not really for each so it
seemed confusing.  The second loop starts in the middle of chain so it
can't be written.
> > !   FOR_EACH_STATIC_INITIALIZER (vnode)
> Uhm this looks wrong, shouldn't this for FOR_EACH_STATIC_VARIABLE?

No, see the analyze_variable_change.

Thanks for looking into the patch,
Honza


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]