This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: add an assert to flow.c


> 
> This assertion prevents us from wandering to emit_move_insn with a null
> RTX.  Okay for the trunk?
> 
> 2006-12-19  Ben Elliston  <bje@au.ibm.com>
> 
>         * flow.c (initialize_uninitialized_subregs): Ensure that the rtx
>         zero constant for the mode of param.retval is non-NULL.
> 
> Index: flow.c
> ===================================================================
> --- flow.c      (revision 120017)
> +++ flow.c      (working copy)
> @@ -1557,6 +1557,7 @@ initialize_uninitialized_subregs (void)
>               if (param.retval != NULL_RTX)
>                 {
>                   start_sequence ();
> +                 gcc_assert (CONST0_RTX (GET_MODE (param.retval)) !=
> NULL_RTX);

I would have written it as this (without the != NULL_RTX):
gcc_assert (CONST0_RTX (GET_MODE (param.retval)));
But then again all of this code is being removed with the merge of the dataflow branch.

-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]