This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: libgomp bootstrap failure on i486-linux with --enable-targets=all


On Sun, Dec 17, 2006 at 02:52:10PM +0100, Matthias Klose wrote:
> 
> updated patch attached (keeping the -mtune settings). libgomp
> testsuite shows no failures with
> RUNTESTFLAGS='--target_board=unix\{-m64,\}' make check. ok to checkin?
> 
> 2006-12-17  Matthias Klose  <doko@debian.org>
> 
> 	* configure.tgt (i[456]86-*-linux*): Only add ia32 specific
> 	flags if not building with -m64.
> 	* testsuite/lib/libgomp-dg.exp (libgomp_init): Don't add -march
> 	flag for i?86-*-* targets, if current target matches -m64.

I'll let the libgomp maintainers review this, but

> -    if [istarget i?86-*-*] {
> +    if { [istarget i?86-*-*] && [string match *-m64* $current_target_name] == -1} {

The second condition should be [is-effective-target ilp32].

Test support should avoid looking for options like -m32 and -m64 because
compilers can usually be configured to generate either one by default.

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]