This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] PR30014 INQUIRE (iolength = xx) limited to kind=4


On Fri, Dec 15, 2006 at 09:30:56PM -0800, Jerry DeLisle wrote:

:REVIEWMAIL:

Hi Jerry,

> ping
> 
> Also, should I increase size parameter as well? Any opinions?

We already have an incompatible change for 4.2 (the memory
allocation interface), so I tend to think we should put this
into 4.2 a well.

I think regression-tests on 32-bit systems are necessary for
this, if at all possible also on big- and little endian machines.

> 
> Jerry DeLisle wrote:
> >:ADDPATCH fortran:
> >
> >The attached patch changes the type to GFC_IO_INT which will either be 
> >kind=4 or kind=8 depending on the system.  The patch is very straight 
> >forward.  I don't see any point giving a warning if a user specifies a 
> >variable of kind=8 in a -std=f95 situation.  If others feel stronger 
> >about this I will do it.

If it is something that can be diagnosed easily, I'd be in favor
doing the warning.

> >A test case for this will require a 
> >lot of memory and consumes time.  I suggest we go without one for this.  
> >I have attached the test case that I used to check this out.

I don't quite understand why it would take so long.  Did it
actually do so during your testing?  Would it do the same
for an allocatable array?

Regards
	Thomas


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]