This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH RFA: Add support for -Wparentheses to the C++ frontend (PR c++/19564)
- From: Benjamin Kosnik <bkoz at redhat dot com>
- To: Ian Lance Taylor <iant at google dot com>
- Cc: gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Wed, 13 Dec 2006 11:19:35 +0100
- Subject: Re: PATCH RFA: Add support for -Wparentheses to the C++ frontend (PR c++/19564)
- References: <m37iwxxaqh.fsf@localhost.localdomain>
> This patch includes the fixes to libstdc++ to avoid the new warnings.
> These are logically separate. I included them in this patch because
> they are mechanical, but I can break them out if preferred.
>
> This has been tested with a bootstrap and testsuite run (including
> libstdc++ testsuite) on i686-pc-linux-gnu.
Looks good to me.
I think it might be a good idea to build with -Wparentheses now that
you've cleaned things up. To do so, you'll need to edit WARN_FLAGS in
GLIBCXX_EXPORT_FLAGS.
That part is pre-approved, if you think it's worthwhile.
-benjamin