This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)

From: Andreas Schwab <schwab at suse dot de>
To: Tobias Burnus <burnus at net-b dot de>
Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, "'fortran at gcc dot gnu dot org'" <fortran at gcc dot gnu dot org>
Date: Sun, 10 Dec 2006 20:13:26 +0100
Subject: Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
References: <456DE55F.8000201@net-b.de> <45748891.2040300@net-b.de> <20061209213353.GA13405@meiner.onlinehome.de> <457BF272.20502@net-b.de> <je3b7nwxx6.fsf@sykes.suse.de> <457C542C.6050801@net-b.de>

Tobias Burnus <burnus@net-b.de> writes:

> Hi Andreas, hi all,
>
>
> +#if HAVE_GETTIMEOFDAY  [...]
> +#if GETTIMEOFDAY_ONE_ARGUMENT
> +    if (!gettimeofday (&tp))
> +#else [...]
> +#if HAVE_STRUCT_TIMEZONE
> +    if (!gettimeofday (&tp, &tzp))
> +#else
> +    if (!gettimeofday (&tp, (void *) 0))
> +#endif /* HAVE_STRUCT_TIMEZONE  */
>
> Andreas Schwab wrote:
>> The timezone information is never used, why not always passing NULL for
>> it?  This is the only use of gettimeofday in libgfortran, it would also
>> make it possible to eliminate a runtime configure check.
>>   
> I don't know what you mean by runtime configure check.

AC_TRY_RUN.  Runtime checks are bad for cross compiling.

Andreas.

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
PGP key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

References:
- Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
  - From: Tobias Burnus
- Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
  - From: Thomas Koenig
- Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
  - From: Tobias Burnus
- Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
  - From: Andreas Schwab
- Re: [patch,fortran] Fix corner case where consecutive calls to date_and_time can return times out of sequence (PR30015)
  - From: Tobias Burnus

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]