This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] PR30096 - Fixes for entity ambiguity and interfaces (PR29975, PR30068)


On Sat, Dec 09, 2006 at 10:57:01AM +0100, Paul Thomas wrote:
>   static int
>   check_interface1 (gfc_interface * p, gfc_interface * q0,
> ! 		  int generic_flag, const char *interface_name,
> ! 		  int referenced)

I would prefer "bool referenced" because this ...

>   	  {
> ! 	    if (referenced)

is a logical expression and 

> !       /* Originally, this test was aplied to host interfaces too;
> ! 	 this is incorrect since host associated symbols, from any
> ! 	 source, cannot be ambiguous with local symbols.  */
> !       k = sym->attr.referenced || !sym->attr.use_assoc;

this is a logical expression.

Other than this nitpicking, the patch is OK.

-- 
Steve


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]