This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Improve PR29433, don't duplicate identifier names in dwarf2out

On Wed, 6 Dec 2006, Mark Mitchell wrote:

> Richard Guenther wrote:
> > On Fri, 1 Dec 2006, Mike Stump wrote:
> > 
> >> On Nov 30, 2006, at 11:15 PM, Mark Mitchell wrote:
> >>>>>> On Thu, 2006-11-30 at 17:18 +0100, Richard Guenther wrote:
> >>>>>>> This patch changes dwarf2out.c to not duplicate the strings in
> >>>>>>> identifier
> >>> This patch is OK, thanks!
> >> The dwarf2 changes I think are safe enough to consider for 4.2, Richard, if
> >> you agree, I'd be nice to put them in 4.2 as well.
> > 
> > I agree in principle - but this isn't a regression, so ...
> > 
> > Mark, is this ok for 4.2 as well?
> I think that to put this on 4.2, we need a little bit of rigor: measure
> something and show that it uses some significant amount less memory.
> We've historically put compile-time improvements on release branches if
> they seemed safe, and this qualifies.  So, let's just prove it actually
> does something useful, which we certainly expect, and then it's OK.

On the testcase from PR29433 we get a 1.4GB improvement in memory usage
compiling with -O0 -g.


Richard Guenther <>
Novell / SUSE Labs

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]