This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: VRP speedup
Jan Hubicka wrote:
>> On Sun, 2006-12-03 at 15:21 +0100, Jan Hubicka wrote:
>>> + return tcmp == boolean_true_node;
>> I would not do that, I would just do integer_onep (tcmp).
>> As I don't trust fold_binary_to_constant returning always
>> boolean_true_node.
>
> It is what old code did and I must say I can't figure out way how the
> fold_binary_to_constant can correctly behave otherwise.
It might want to return a true value with a different (typedef) type,
for better debugging purposes. Therefore, I believe that tests against
boolean_{true,false}_node are wrong.
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713