This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite/C] check target supports large long double and fix Wconversion tests failures


"Manuel López-Ibáñez" <lopezibanez@gmail.com> writes:

| On 02 Dec 2006 16:05:42 +0100, Gabriel Dos Reis
| <gdr@integrable-solutions.net> wrote:
| 
| > There is an important point, however:  If with -fsigned-char, the
| > resulting value of the literal is negative, them we have portability
| > problem.  And we better detect that.  Note that the test here is about
| > testing a literal character, not just a random integer.
| > Consequently, I think Jakub's suggestion still holds.
| 
| Would you approve the patch if I make that change?

Yes.

| (BTW, with -fsigned-char, the value of the literal is negative even if
| the target's char type is unsigned.

that is expected.

-- Gaby


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]