This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove useless loop from alias.c


On 11/25/06, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
Hi,

This patch removes an expensive loop in alias.c:init_alias_analysis.
The comment before the loop already says it:

-     This loop may not be needed any longer now that the main loop does
-     a better job at propagating alias information.  */

Well, it's not needed as far as I can tell.  I've counted the number
of passes in this loop for ~600 preprocessed C and C++ files from GCC
itself, and there was *never* more than one pass, i.e. nothing changed
in the loop So even if this is still a useful loop, it's questionable
whether the cost/benefit ratio justifies keeping the loop.

This is good enough numbers for me :)


The patch is okay, thanks!


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]