This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Small cleanups to cse.c


On Sat, 2006-11-25 at 12:32 -0700, Roger Sayle wrote:
> I did do a quick audit of the gcc/ directory to see if I could find
> any instances of "if (foo) gcc_unreachable();"  Although not exhaustive,
> the vast majority of uses of gcc_unreachable are in switch statements
> for handling invalid cases, or at the very end of long
> if-then-else-if-then-else chains.

There are some if foo contains side effects.  I remember one because it
had broke bootstrap when it was converted in the first place.  Though
those should most likely be conveted to:
x = foo;
gcc_assert (x);

If not already done.

Thanks,
Andrew Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]