This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [gfortran,patch] Handle "%3$d"-style format specifiers in error.c

From: Brooks Moses <brooks dot moses at codesourcery dot com>
To: gcc-patches at gcc dot gnu dot org
Cc: fortran at gcc dot gnu dot org
Date: Sat, 25 Nov 2006 10:51:58 -0800
Subject: Re: [gfortran,patch] Handle "%3$d"-style format specifiers in error.c
References: <AA28EA2F-10C1-47B6-837C-BBB948290C9E@gmail.com> <48C35A2B-091F-496D-BC19-5EE63C57B17A@gmail.com>

FX Coudert wrote:

Here's what I commited to mainline, taking into account Andreas' and Brooks' remarks.

Thanks Brooks for reviewing this,

Hmm -- perhaps I should have been clearer that my "this otherwise looks ok to me" couldn't count as a formal review, because I'm not a maintainer? If so, my apologies.

On the other hand, my understanding of the write access policies is that since FX is a maintainer he doesn't need a formal review in order to commit things, and so my informal review is more than sufficient. (And, with that said -- I did give it the same level of scrutiny I would have had I been giving it a formal review.)

- Brooks

Follow-Ups:
- Re: [gfortran,patch] Handle "%3$d"-style format specifiers in error.c
  - From: FX Coudert

References:
- [gfortran,patch] Handle "%3$d"-style format specifiers in error.c
  - From: FX Coudert
- Re: [gfortran,patch] Handle "%3$d"-style format specifiers in error.c
  - From: FX Coudert

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]