This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Small cleanups to cse.c

From: "Steven Bosscher" <stevenb dot gcc at gmail dot com>
To: "Eric Botcazou" <ebotcazou at libertysurf dot fr>
Cc: gcc-patches at gcc dot gnu dot org, "Sayle, Roger" <roger at eyesopen dot com>
Date: Sat, 25 Nov 2006 17:22:08 +0100
Subject: Re: [PATCH] Small cleanups to cse.c
References: <200611251612.06978.steven@gcc.gnu.org> <200611251718.14662.ebotcazou@libertysurf.fr>

On 11/25/06, Eric Botcazou <ebotcazou@libertysurf.fr> wrote:

> @@ -3715,9 +3710,11 @@ record_jump_equiv (rtx insn, int taken)
>    int reversed_nonequality = 0;
>    enum rtx_code code;
>
> +#ifdef ENABLE_CHECKING
>    /* Ensure this is the right kind of insn.  */
> -  if (! any_condjump_p (insn))
> -    return;
> +  gcc_assert (any_condjump_p (insn));
> +#endif

gcc_assert is generally not guarded like that. Could you add a small comment?

Actually, that looks like a mistake. I should have typed

 if (!any_condjump_p (insn))
   gcc_unreachable ();

there, without the ENABLE_CHECKING. I'll fix that. Thanks for catching this.

Gr.
Steven

Follow-Ups:
- Re: [PATCH] Small cleanups to cse.c
  - From: Eric Botcazou

References:
- [PATCH] Small cleanups to cse.c
  - From: Steven Bosscher
- Re: [PATCH] Small cleanups to cse.c
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]