This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Add --with-mpfr-include, --with-mpfr-lib, --with-gmp-include and --with-gmp-lib


Hi Kaveh,

thanks for continuing to drive this!

On Sat, 18 Nov 2006, Kaveh R. GHAZI wrote:
> +@item --with-gmp=@var{pathname}
> +@itemx --with-gmp-include=@var{pathname}
> +@itemx --with-gmp-lib=@var{pathname}
> +@itemx --with-gmp-dir=@var{pathname}
> +@itemx --with-mpfr=@var{pathname}
> +@itemx --with-mpfr-include=@var{pathname}
> +@itemx --with-mpfr-lib=@var{pathname}
> +@itemx --with-mpfr-dir=@var{pathname}
> +If you don't have GMP (the GNU Multiple Precision library) and the

I recommend using "do not" instead of "don't here".

> +MPFR Libraries installed in a standard location and you want to build
> +GCC, you can explicitly specify the directory where they are installed
> +(@samp{--with-gmp=gmpinstalldir}, @samp{--with-mpfr=mpfrinstalldir}).
> +The @option{--with-gmp=gmpinstalldir} option is shorthand for
> +@option{--with-gmp-lib=gmpinstalldir/lib} and
> +@option{--with-gmp-include=gmpinstalldir/include}.  Likewise the
> +@option{--with-mpfr=mpfrinstalldir} option is shorthand for
> +@option{--with-mpfr-lib=mpfrinstalldir/lib} and
> +@option{--with-mpfr-include=mpfrinstalldir/include}.  If these
> +shorthand assumptions are not correct, you can use the explicit
> +include and lib options directly.

Joseph generally is more authoritative than me on questions like this, but 
I believe we need to markup gmpinstalldir and mpfrinstalldir in the examples
(@samp{...}) above as @var{gmpinstalldir} and @var{mpfrinstalldir}, even (or
especially) for --with-gmp-lib, --with-gmp-include, etc.

What is the difference between --with-gmp= and --with-gomp-dir?

> [...] If you compiled these libraries
> +from source but don't want to install them, another alternative is to
> +specify the directories where you built them using
> +(@samp{--with-gmp-dir=gmpbuilddir},
> +@samp{--with-mpfr-dir=mpfrbuilddir}).

Trying to understand this, I got rather confused initially (though this 
was due to me not reading sufficiently careful) about --with-gmp= versus 
--with-gmp-dir.

Have you considered about changing --with-gmp-dir to --with-gmp-builddir, 
and similarly changing --with-mpfr-dir to --with-mpfr-builddir?  That would
have avoided/reduced my confusion. ;-)

I appreciate that this predates your current patch, and am sorry for not
reporting/suggesting this before.

Gerald


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]