This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC, patch] Fix pr24783 : resolves implicit type from wrong namespace


FX Coudert wrote:
2006-11-14 Bernhard Fischer <>

    PR fortran/24783
    * resolve.c (resolve_variable): Get the implicit type from the
    symbols namespace rather than the default namespace.

Apart from the fact that your email address is missing in the ChangeLog entries, this patch looks OK to me. However, I'd prefer a second opinion, as you seem not to be too sure about it and I'm not an expert in the resolution mechanism either.


So, could someone else give it a look (it's a one-liner, so it won't be too long to read, I promise), please?

FX

I have looked it over also and I think it is OK. The function gfc_get_default_type being called defaults to gfc_current_ns if it is given NULL. In the test case, the namespace is not always the current one.

OK for trunk and give it a few days before 4.2 after testing.

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]