This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C/C++ PATCH] Reorganize c-common.c's convert_and_check


On Thu, 16 Nov 2006, Manuel Lopez-Ibanez wrote:

> Hi Roger,
> 
> I am trying to integrate your patch with my patch at
> http://gcc.gnu.org/ml/gcc-patches/2006-11/msg00248.html to avoid
> conflicts.

I'd rather not rereview the same patch with a second patch integrated into 
it, and a union of your patch with Roger's would violate the principle of 
patches being minimal indivisible units.  I approved your patch as is with 
the expectation that it would be applied as is.  Once you have committed 
it to mainline, and once a new version of Roger's patch updated to apply 
to mainline with your patch applied has been posted, I can then review the 
new version of Roger's patch (having approved your patch, there's no point 
in reviewing the old version).

-- 
Joseph S. Myers
joseph@codesourcery.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]