This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] Remove closing periods from error messages.


Brooks Moses wrote:
According to the GNU error-message standards, error messages should not end with periods. GFortran has a dozen or so errors and warnings that violate this rule, which I found with the following grep patterns:

  grep -A3 'gfc_error' * | grep '\."'
  grep -A3 'gfc_warn' * | grep '\."'

Whether or not this rule is appropriate for the verbose error messages of the form that GFortran emits (as opposed to the terse single-line ones envisioned by the GNU standards) is debatable, I think, but in any case it's probably best to be consistent. Thus, the attached patch at least applies consistency.

---------------------------------------------------------------------
2006-11-15  Brooks Moses  <brooks.moses@codesourcery.com>

    * data.c: Remove trailing periods from error messages.
    * decl.c: Likewise.
    * expr.c: Likewise.
    * io.c: Likewise.
    * match.c: Likewise.
    * module.c: Likewise.
    * options.c: Likewise.
    * resolve.c: Likewise.
    * symbol.c: Likewise.
    * trans-io.c: Likewise.

---------------------------------------------------------------------

Regression tested on i686-pc-linux-gnu. Ok for trunk?

- Brooks

OK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]