This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gfortran,patch] Fix PR27588: Add substring-out-of-bounds check

On Sat, Nov 11, 2006 at 12:47:50AM +0100, Tobias Burnus wrote:
> :ADDPATCH fortran:
> The attached patch adds a "substring out of bounds" check, in the spirit
> of trans-array.c's gfc_trans_array_bound_check.
> This is an improved version; the first
> ( didn't
> displayed the right line number and no variable name; the second by FX
> ( added the
> variable name  - and this version fixes the line-number display.
> I used CBND1, CBND2 and CBND4 of
>, which all are
> detected (with variable name), which increases our diagnostics
> statistics from 34% -> 39% ;-)
> FX wrote (regarding his patch): "I've been working to find how to output
> the variable name, [...] but it still doesn't work in all cases."
> If you find an example where it does not work, I'm happy to look at it.
> (I didn't find one, but I didn't look for it extensively)
> Compiled and regtested on x86_64-unknown-linux-gnu-gcc.
> Ok for the trunk?

The patch is OK with an appropriate ChangeLog entry.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]