This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch, fortran] error.c: Cleanup, refactoring, column numbers in filename lines.
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Brooks Moses <brooks dot moses at codesourcery dot com>
- Cc: fortran at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: Mon, 13 Nov 2006 13:35:02 -0800
- Subject: Re: [patch, fortran] error.c: Cleanup, refactoring, column numbers in filename lines.
- References: <454EE4A8.8060709@codesourcery.com> <454FD93E.1090004@codesourcery.com>
On Mon, Nov 06, 2006 at 04:54:22PM -0800, Brooks Moses wrote:
> :ADDPATCH fortran:
>
> Brooks Moses wrote:
> >fortran/ChangeLog:
> >
> >2006-11-05 Brooks Moses <brooks.moses@codesourcery.com>
> >
> > * error.c (show_loci): Move column-offset calculation to
> > show_locus.
> > (show_locus): Remove blank lines before "Included in"
> > lines, clean up code, calculate column-offsets, print
> > column number is error-header lines as appropriate.
> > (error_integer): (new function) Print integer to error
> > buffer.
> > (error_print): Use error_integer, avoid possible buffer
> > overflows from buggy error formats.
> >
> >testsuite/ChangeLog:
> >
> >2006-11-05 Brooks Moses <brooks.moses@codesourcery.com>
> >
> > * lib/gfortran-dg.exp (gfortran-dg-test): Ignore column
> > numbers in error message headers.
> >
> >------------------------------------------------------------------
> >
> >Ok for trunk, once someone fixes the bootstrap, and I get a chance to
> >regression test it there?
>
> Update: I now have a working trunk build tree, and the combined patch
> has passed regression testing on i686-pc-linux-gnu. Ok to commit?
>
OK for trunk. If you backported and tested the patch on 4.2, then
I think you should apply it there as well.
--
Steve