This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Avoid invalid RTL sharing

From: Jan Hubicka <hubicka at ucw dot cz>
To: Roger Sayle <roger at eyesopen dot com>
Cc: Jan Hubicka <jh at suse dot cz>, gcc-patches at gcc dot gnu dot org
Date: Sat, 11 Nov 2006 15:13:18 +0100
Subject: Re: Avoid invalid RTL sharing
References: <20061109222913.GA31179@kam.mff.cuni.cz> <Pine.LNX.4.44.0611091637410.1142-100000@www.eyesopen.com>

Hi,
> 
> This is OK for mainline.  Thanks for taking the time to hunt down these
> internal invariant violations.  Presumably, there'll be negligible effects
> on memory usage with this change?  If your memory usage tester complains
> after you check this in, there are some places we can be clever to avoid
> calling copy_rtx, but I doubt this is worth the additional effort.

Just for a record, memory checker didn't complained about this patch at
all. The copying really happens in quite rare corner cases (this is also
why the bugs like this stays latent for years).
> 
> p.s. Period after "Copy stored_mode" in the i386.c ChangeLog entry above.

Oops, I forgot about that while comitting.  I will try to mind adding it
on my next commit.  I am sorry for that!

Thanks,
Honza
> 
> Roger
> --

References:
- Avoid invalid RTL sharing
  - From: Jan Hubicka
- Re: Avoid invalid RTL sharing
  - From: Roger Sayle

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]