This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, gomp]: Reject negative values for env variables


Richard Henderson wrote:

On Thu, Oct 26, 2006 at 02:37:35PM +0200, Uros Bizjak wrote:


+ if (errno || (signed long) value < 0)



I guess this patch is ok.


I don't really see that the schedule instance needs anything
but the errno check; setting the chunk size to 0x80000000 is
legal, though in practice useless.


I have committed a check for errno only. IIUC, Jakub proposes a fix for signed/unsigned issue in other place.

Thanks,
Uros.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]