This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, gomp]: Reject negative values for env variables


On Thu, Nov 09, 2006 at 10:01:56AM -0800, Richard Henderson wrote:
> On Thu, Oct 26, 2006 at 02:37:35PM +0200, Uros Bizjak wrote:
> > >+  if (errno || (signed long) value < 0)
> 
> I guess this patch is ok.
> 
> I don't really see that the schedule instance needs anything
> but the errno check; setting the chunk size to 0x80000000 is
> legal, though in practice useless.

GOMP_loop_runtime_start etc. pass gomp_run_sched_chunk
(unsigned long) to gomp_loop_static_start etc. (but there
the argument is signed long, ws->chunk_size is signed long too
).  As the signed vs. unsigned long is part of the ABI (GCC generated
calls store signed long values), I think we can't easily change that.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]