This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [fixed-point] Patch to parse _Fract, _Accum, _Sat


On 11/8/06, Chao-ying Fu <fu@mips.com> wrote:
Hello,

Thanks for your review!

> > +  unsigned saturating_flag : 1;
>
> You probably have noticed that the flags are grouped in sets of 8 bits,
> and that there are four groups of 8 bits.  You've added another bit,
> and increased the size of tree_common by a full word.  Is that change
> on purpose?

  About saturating_flag, if I cannot add a new flag in either tree_common
or tree_type, I will need to use lang_flag_2  in c-tree.h
Ex:
#define C_TYPE_SATURATING(TYPE) TYPE_LANG_FLAG_2 (TYPE)

Neh, you're implementing a set of types in the middle-end, so using a C only flag is Badness.

I'd keep it as you have it with saturing_flag for now, but add a FIXME
there so that it doesn't slip in if/when you merge to the trunk many
months from now.  We're probably going to have to shuffle with those
flags anyway when all the 'tree' cleanup projects go in.

Gr.
Steven


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]