This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR29699 - ICE in trans-decl.c


:REVIEWMAIL:

On Tue, Nov 07, 2006 at 11:29:02AM +0100, Paul Richard Thomas wrote:
> Regested on x86_ia64/FC5 and amd64/Cygwin_NT - OK for trunk and 4.2?
> 
> Paul
> 
> 2006-11-07  Paul Thomas <pault@gcc.gnu.org>
> 
> 	PR fortran/29699
> 	* trans-array.c (structure_alloc_comps): Detect pointers to
> 	arrays and use indirect reference to declaration.
> 	* resolve.c (resolve_fl_variable): Tidy up condition.
> 	(resolve_symbol): The same and only add initialization code if
> 	the symbol is referenced.
> 	* trans-decl.c (gfc_trans_deferred_vars): Call gfc_trans_
> 	deferred_array before gfc_trans_auto_array_allocation.
> 
> 2006-11-07  Paul Thomas <pault@gcc.gnu.org>
> 
> 	PR fortran/29699
> 	* gfortran.dg/alloc_comp_auto_array_1.f90: New test.
> .

The patch itself is OK, but I have a comment on the testcase: in the
main program (before the CONTAINS line), there is no "interesting"
executable code -- only a type definition and a initialization of an
integer.  There's more interesting executable code in the subroutines,
but no subroutine is called, so not much is tested at runtime.  Perhaps
a 

CALL extend_lists2

should be added to the main program?


        Erik


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]