Re: [patch] bootstrap failure in obj-c++

[Mike Stump <mrs at apple dot com>]

On Nov 1, 2006, at 7:31 PM, Andrew Pinski wrote:
> On Wed, 2006-11-01 at 23:51 +0100, Andreas Tobler wrote:
> > Hi all,
> >
> > I do not have time to wait!
> >
> > This patch caused a bootstrap failure for obj-c++:
> >
> > http://gcc.gnu.org/ml/gcc-cvs/2006-11/msg00013.html
> >
> > With the appended patch we get back to the previous results, tested  
> > on
> > ppc-linux and sparc-solaris.
> >
> > I don't know if correct or not. But I need to get it out since I have
> > lots of stuff pending. (not for gcc)
> >
> > ok?
>
> This is obvious as cp_finish_file is named  
> cp_write_global_declarations
> and is called via LANG_HOOKS_WRITE_GLOBALS.

Well, actually, they are both wrong, or at least incomplete.  The  
effect is to move metadata writing up earlier, thus breaking things.   
This is wrong.  Geoff, did you build obj-c++?  Did you test it?   
Fariborz tells me that the testsuite should catch such things.