This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, fortran] pr21061 - gfortran ignores -Werror


On Thu, Nov 02, 2006 at 03:30:03PM +0100, Bernhard Fischer wrote:
>On Fri, Oct 20, 2006 at 01:05:35AM -0700, Brooks Moses wrote:
>>Steve Kargl wrote (on 2006/09/17):
>>>On Thu, Sep 14, 2006 at 02:59:02PM +0200, Bernhard Fischer wrote:
>>>>Attached is a revised and much simpler fix for PR fortran/21061 where
>>>>-Werror was ignored. The attached patch makes sure that we exit(1)
>>>>properly even for warnings.
>>>
>>>I think the patch is ok.
>>
>>It looks like this never got committed, however.
>>
>>(See http://gcc.gnu.org/ml/gcc-patches/2006-09/msg00551.html for the 
>>original patch post.)
>>
>>If this was fixed in some other manner, this should probably be removed 
>>from the patch queue.
>
>It was not yet fixed nor committed due to problems with dejagnu.
>See http://gcc.gnu.org/ml/gcc/2006-10/msg00408.html
>
>I'm rewriting the testcases (for free- and fixed form) now and want to
>see if i can use dg-final { scan-assembler ".*" }.
>
>If this does not work out, then i propose to omit the testcases since
>they are just ment to check that no object is created and that we
>exit(1) if gfc_warning{,_now} or gfc_notify_std was called.

Didn't work out for me.
FWIW, i tried
! { dg-do compile }
! { dg-options " -Werror" }
! { dg-final { scan-assembler ".*" { xfail *-*-*-* } } }
! PR fortran 21061

With the unsatisfactory answer of
$ diff -u gfortran.sum gcc/testsuite/gfortran/gfortran.sum | egrep -v "^\+PASS"
@@ -10063,6 +10063,18 @@
 PASS: gfortran.dg/verify_2.f90  -O3 -g  execution test
 PASS: gfortran.dg/verify_2.f90  -Os  (test for excess errors)
 PASS: gfortran.dg/verify_2.f90  -Os  execution test
+ERROR: gfortran.dg/warnings_are_errors_1.f  -O : error executing dg-final: couldn't open "warnings_are_errors_1.s": no such file or
directory
+UNRESOLVED: gfortran.dg/warnings_are_errors_1.f  -O : error executing dg-final: couldn't open "warnings_are_errors_1.s": no such file or directory
+ERROR: gfortran.dg/warnings_are_errors_1.f90  -O : error executing dg-final: couldn't open "warnings_are_errors_1.s": no such file or directory
+UNRESOLVED: gfortran.dg/warnings_are_errors_1.f90  -O : error executing dg-final: couldn't open "warnings_are_errors_1.s": no such file or directory
 PASS: gfortran.dg/where_nested_1.f90  -O  (test for excess errors)
 PASS: gfortran.dg/write_0_pe_format.f90  -O0  (test for excess errors)
 PASS: gfortran.dg/write_0_pe_format.f90  -O0  execution test
@@ -15808,9 +15820,10 @@
 
 		=== gfortran Summary ===
 
-# of expected passes		15010
+# of expected passes		15018
 # of unexpected failures	8
 # of expected failures		7
+# of unresolved testcases	2
 # of unsupported tests		16
 /home/cow/obj.ia32/gcc-4.3/gcc/testsuite/gfortran/../../gfortran
version 4.3.0 20061102 (experimental)

So i'll let dejagnu alone and simply omit the testcases.
I already wasted far too much time (and procrastinated the checkin!) for
this really simple glitch, given that the first incarnation i sent to
this list dates back to Sat, 26 Nov 2005 17:46:20 +0100.

I'll commit to trunk (and 4.2, 4.1 if i get a change to regtest them on
these) unless somebody raises objections within 24 hours from now on.

Thanks,


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]