This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH]: PR29335 use MPFR for builtin sincos
- From: Roger Sayle <roger at eyesopen dot com>
- To: "Kaveh R. GHAZI" <ghazi at caip dot rutgers dot edu>
- Cc: Richard Guenther <richard dot guenther at gmail dot com>, <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 1 Nov 2006 18:23:28 -0700 (MST)
- Subject: Re: [PATCH]: PR29335 use MPFR for builtin sincos
On Wed, 1 Nov 2006, Kaveh R. GHAZI wrote:
> Is there any other testcase you would like me to try or can I install
> the patch?
The patch is OK for mainline. It would also be nice if you could
turn the sincos(zero,&s,&c) test case into something suitable for
GCC's dejagnu testsuite and check that in. And just for good luck
perhaps something like:
void foo(double x)
double s, c;
if (x == 0.0)
/* Check s and c. */
However these new test cases can be committed as a follow-up patch.
We've no reason to believe the tree-ssa passes can't handle the new
non-gimple (*sp=X, *cp=Y) idiom that sincos folding can now produce,
but it does no harm as to make sure things don't break in future.
[I'll admit that I'm a bit curious as to which pass actually performs
the simplification you tested for, but it'll be easy enough for me
to investigate this for myself once your patch goes in. :-)]
Thanks again, and to Richard for looking things over.