This is the mail archive of the
mailing list for the GCC project.
Re: RFC: patch to add ISO_FORTRAN_ENV intrinsic module
- From: Paul Thomas <paulthomas2 at wanadoo dot fr>
- To: François-Xavier Coudert <fxcoudert at gmail dot com>
- Cc: GFORTRAN <fortran at gcc dot gnu dot org>, GCC-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 30 Oct 2006 21:58:28 +0100
- Subject: Re: RFC: patch to add ISO_FORTRAN_ENV intrinsic module
- References: <firstname.lastname@example.org>
I am having some difficulty with this proposal; perhaps because I am
ignorant on the format of the F2003 intrinsic modules. Why is it
necessary to have custom code for each new intrinsic module? Would it
not be better, as I wrote elsewhere, to have .mod files and a library in
a special directory for intrinsic modules? That way, the existing
module code could be used, with the addition of your bits to sort out
intrinsic and non-intrinsic.
Hi all,What structure has Christopher adopted?
Attached patch adds the intrinsic ISO_FORTRAN_ENV module to gfortran,
as well as general support for intrinsic modules and the F2003-style
USE statement. I first thought this might wait until the ISO_C_BINDING
module is added, but seeing that Christopher encounters problems with
his paperwork, we agreed it's best to submit it now, and then it will
be relatively easy to change his patch (I volunteer to do it) to use
the framework I'm proposing here.
This seems OK to me. However, are we perhaps being a bit parsimonious
with attribute bits? Maybe an intrinsic_module bit would be better?
-- I've used the attr.intrinsic bit for the module symbol to
specifiy that it's an intrinsic module. Except one line in resolve.c
(see diff), it seems to be safe. However, I'd like
a) to be sure that, for every user module symbol created, the
intrinsic bit is set to 0, so that we check that a non-intrinsic and
an intrinsic module of the same name aren't used
You'll have to find the module symbol, check if it's intrinsic and throw
on the new module being non-intrinsic.
b) the code USEing non-intrinsic modules (in module.c) to issue an
error if an intrinsic module of the same name was already USEd; ie,
I'd like the following to error out (while, with my patch, it does
...and the other way round, I suppose!
end module iso_fortran_env
use, intrinsic :: iso_fortran_env
use, non_intrinsic :: iso_fortran_env ! This should issue an error
end program foo
Anyway, it's impressive to see you launching into module.c - convince me
that what you are doing is OK!