This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] PR29033: i18n issue
On Mon, 2006-10-30 at 15:49 +0100, Dirk Mueller wrote:
> On Sunday 29 October 2006 22:10, Joseph S. Myers wrote:
> > If the string does not appear directly as the msgid/gmsgid argument to the
> > diagnostic function, I recommend marking it up with G_ (see
> > ABOUT-GCC-NLS).
> Thank you!
> Indeed, I was assuming that xgettext would pick both strings up, but it
> didn't. I've annotated the calls of warning() which I touched in the last two
> commits with G_ and verified via gcc.pot that this change made the strings
> appear in the pot file.
> Thanks to Roger I also corrected my coding style to match the convention. I've
> bootstrapped, make gcc.pot-tested and installed the following patch.
> 2006-10-30 Dirk Mueller <firstname.lastname@example.org>
> * typeck.c (build_unary_op): Fix indenting. Use G_().
I would rather have the code look like:
if (code == LROTATE_EXPR)
warning (0, "left rotate count is negative");
warning (0, "right rotate count is negative");
because this makes the code a little cleaner and a harder to get wrong
the next time we change it.
Though I don't know which one is preferred by the coding style.