This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Dump info for variable expansion
- From: Revital1 Eres <ERES at il dot ibm dot com>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 30 Oct 2006 11:56:01 +0200
- Subject: Re: [PATCH] Dump info for variable expansion
Hello,
I apologize for that. Here is the patch again:
Index: loop-unroll.c
===================================================================
--- loop-unroll.c (revision 117342)
+++ loop-unroll.c (working copy)
@@ -1603,7 +1603,15 @@
|| FLOAT_MODE_P (mode2))
&& !flag_unsafe_math_optimizations)
return NULL;
-
+
+ if (dump_file)
+ {
+ fprintf (dump_file,
+ "\n;; Expanding Accumulator ");
+ print_rtl (dump_file, dest);
+ fprintf (dump_file, "\n");
+ }
+
/* Record the accumulator to expand. */
ves = XNEW (struct var_to_expand);
ves->insn = insn;
Thanks,
Revital
Steven Bosscher <stevenb.gcc@gmail.com> wrote on 29/10/2006 14:42:40:
> On Tuesday 10 October 2006 12:58, Revital1 Eres wrote:
> > :ADDPATCH middle-end (variable expansion in rtl loop-unroll):
> >
> > Hello,
> >
> > The attached patch adds dump info
> > when an accumulator is expanded in the rtl loop optimizer.
> > I also added a testcase for it.
> >
> > O.K. for mainline?
>
> Not OK, the formatting is wrong. You did:
>
> + if (dump_file){
> + fprintf (dump_file,
> + "\n;; Expanding Accumulator ");
> + print_rtl (dump_file, dest);
> + fprintf (dump_file, "\n");
> + }
>
> but it should be:
>
> + if (dump_file)
> + {
> + fprintf (dump_file,
> + "\n;; Expanding Accumulator ");
> + print_rtl (dump_file, dest);
> + fprintf (dump_file, "\n");
> + }
>
> which you could have known because this isn't your first patch
> submission.
>
> Otherwise it looks obvious to me.
>
> Gr.
> Steven
>