This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PR6321


Dirk Mueller wrote:

2006-10-29 Dirk Mueller <dmueller@suse.de>

        PR c++/6321
        * c-decl (start_function): Move code for main decl warning ..
        * c-common.c (main_args_warning): .. here.
        * c-common.h (main_args_warning): Declare.

* decl.c(grokfndecl): Use main_args_warning.

        * g++.old-deja/g++.pt/eichin01a.C (main): Fix prototype.
        * g++.old-deja/g++.pt/eichin01b.C (main): Same.
        * g++.old-deja/g++.pt/eichin01.C (main): Same.
        * g++.old-deja/g++.mike/net25.C (main): Same.
        * g++.dg/lookup/exception1.C (main): Same.
        * g++.dg/parse/parens2.C (main): Same.

The idea of this patch is fine, but the function name main_args_warning isn't very good. Please use "check_type_of_main" instead.


OK with that change.

--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]