This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Canonicalize comparisons, fix PR26899

From: kenner at vlsi1 dot ultra dot nyu dot edu (Richard Kenner)
To: rguenther at suse dot de
Cc: gcc-patches at gcc dot gnu dot org, pinskia at gmail dot com, roger at eyesopen dot com
Date: Sat, 28 Oct 2006 16:52:01 EDT
Subject: Re: [PATCH] Canonicalize comparisons, fix PR26899
References: <Pine.LNX.4.44.0610280928020.23999-100000@www.eyesopen.com> <1162065534.3417.1.camel@celery.andrew.com> <Pine.LNX.4.64.0610282237060.3567@zhemvz.fhfr.qr>

>     if ((flag_wrapv || flag_trapv)
>         || (TYPE_UNSIGNED (TREE_TYPE (arg0))
> ! 	  || POINTER_TYPE_P (TREE_TYPE (arg0))))
>       return NULL_TREE;

You've now got a bunch of extra parens and indentation if all are ||.

References:
- Re: [PATCH] Canonicalize comparisons, fix PR26899
  - From: Roger Sayle
- Re: [PATCH] Canonicalize comparisons, fix PR26899
  - From: Andrew Pinski
- Re: [PATCH] Canonicalize comparisons, fix PR26899
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]