This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch,fortran] Allow namelist with internal file (PR 28224)


Tobias,

:REVIEWMAIL:
PR fortran/PR28224
* gfortran.dg/io_constraints_2.f90: Remove check for
using namelists with internal files.
Might it not be better to use -std=f95 for this test....
* gfortran.dg/namelist_internal.f90: New namelist test.
* gfortran.dg/namelist_internal2.f90: New namelist test.
...and to drop this latter?

"New test" should be enough, since its name makes it apparent what it is for. :-)


Aside from these minor points, OK for trunk.


Thanks

Paul
* gfortran.dg/namelist_internal.f90: New namelists test.
* gfortran.dg/namelist_internal2.f90: New namelists test.
By the way, if you decide to use the adjective "namelist", keep it in the singular; in general, a noun used as an adjective stays in the singular.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]