This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libgomp] A couple of patches


On Wed, Oct 18, 2006 at 07:22:00AM +0200, Eric Botcazou wrote:
> I've already pinged them many times...
> 
> http://gcc.gnu.org/ml/gcc-patches/2006-02/msg01300.html

I'd very much prefer, especially given the small size of
config/posix/{lock.c,omp-lock.h}, to avoid the #ifdef mess
and instead create config/posix95/ which would contain a Solaris2.[56]*
override to those two files.  config/linux/ overrides them too,
so there is a precedent in libgomp already.
configure.tgt would just do:
  *-*-solaris2.[56]*)
	config_path="posix95 posix"
	XLDFLAGS="${XLDFLAGS} -lposix4"
	;;

> http://gcc.gnu.org/ml/gcc-patches/2006-02/msg01302.html

This one is obvious.

That said, I'm not libgomp maintainer and can't approve either.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]