This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] mips: Allow larger values for __aligned__


> Sorry, I wasn't being clear enough. The order should be that elfos.h is
> included before the target headers redefine the ELF related defaults, so
> the guard was superfluous.

I had understood.  I still disagree with the removal of the guard though.

> What do you think of the following convservative approach to correct the
> issue?

I think that the conservative approach is to revert the patch and put 
something in config/mips/mips.h instead, as you originally did.  IMHO
tweaking the generic ELF MAX_OFILE_ALIGNMENT during stage 3 is risky.

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]