This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix solaris10 testsuite c99 detection


> The builtins-config.h file determines whether various testcases should
> check C99 features in GCC.  The solaris10 block in there never activated
> because it looks for a macro that's defined in <sys/feature_tests.h> on
> solaris10 but we never include the header.

Right, except in gcc.dg/single-precision-constant.c though.

> Since <sys/types.h> is already included by builtins-config.h, I don't have
> to add any headers I just have to move the solaris block to after where
> <sys/types.h> is already included.  That seems safer to me.

Agreed.

> Tested via "make check" on solaris10 and solaris7.  If there are no
> objections, I'll install it as "obvious" on all active branches after 24
> hours.

I'd check that this doesn't cause new failures to pop up on release branches.
They would not be regressions so we couldn't fix them there.

Thanks for catching this!

-- 
Eric Botcazou


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]