This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Fix PR29254 (cgraph, P1)
- From: Roger Sayle <roger at eyesopen dot com>
- To: Jan Hubicka <jh at suse dot de>, <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 9 Oct 2006 10:43:56 -0600 (MDT)
- Subject: Re: [PATCH] Fix PR29254 (cgraph, P1)
On Mon, 9 Oct 2006, Roger Sayle wrote:
> On Mon, 9 Oct 2006, Richard Guenther wrote:
> > This patch fixes an ICE-after-error (still P1...) by not verifying
> > the cgraph in that case (which is what other entries into that code do).
> After carefully reading Jan's postings and comments on the issue, I
> believe your patch is the correct fix.
My apologies to Jan. I took so long to compose my review e-mail, I
missed the fact that Jan had already posted his approval. The above
comment shouldn't be misinterpreted as a critique of his review, but
rather a confirmation that we're both in agreement on error management
in the middle-end.
Sorry for any confusion, or unintended offense.