This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, take 2] Fix PR target/28946


Rask Ingemann Lambertsen wrote:

It's now been a few days and RTH hasn't voiced an objection. Although
the patch is ugly, I think this is just a consequence of the way GCC's
combiner and RTL instruction selection work, and similar idioms are
commonly used on other platforms.



Note that you could likely use code macros, code attributes, mode macros and mode attributes to reduce the number of patterns in the MD file. I think the i386 shift/rotate instructions are sufficiently uniform that you can do so, even with the "add reg,reg" vs. "sal reg,reg" issue.



Yes, I know... But I was looking for the safest solution to implement new patterns. Undoubtly, there are plenty of possibilities for macro use in i386/*.md, but rest assured that no patches for these issues will be accepted in stage3.

Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]