This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix openmp failures caused by PR19260 fix


Jakub Jelinek wrote:
On Thu, Oct 05, 2006 at 10:24:46AM -0400, Jakub Jelinek wrote:
On Thu, Sep 21, 2006 at 08:05:12PM -0700, Jerry DeLisle wrote:
2006-09-21 Jerry DeLisle <jvdelisle@gcc.gnu.org>

	PR fortran/19260
	* scanner.c (gfc_next_char_literal): Add check for missing '&'
	and set locus to old_locus when not scanning a character literal.
This breaks several tests in libgomp.

Here is a fix that seems to fix all the libgomp testcases, ok to commit?


2006-10-05 Jakub Jelinek <jakub@redhat.com>

	* scanner.c (skip_free_comments): Return bool instead of void.
	(gfc_next_char_literal): Don't return ' ' if & is missing after
	!$omp or !$.  Use skip_{free,fixed}_comments directly instead
	of gfc_skip_comments.

Yes, this is OK to commit. Sorry I did not see that. I don't usually build and test libgomp. I will do that on the next patch.

Jerry


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]