This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix PR28489 - [4.2 Regression] ICE: in move_block_after_check, at haifa-sched.c:4337


Maxim Kuvyrkov <mkuvyrkov@ispras.ru> writes:

> 2006-09-23  Maxim Kuvyrkov  <mkuvyrkov@ispras.ru>
> 
> 	PR rtl-optimization/29128
> 	* sched-ebb.c (advance_target_bb): Use correct condition to
> 	allow interblock movement of speculation checks.
> 	* sched-int.h (IS_SPEC_BRANCY_CHECK_P): New macro.
> 
> 2006-09-23  Maxim Kuvyrkov  <mkuvyrkov@ispras.ru>
> 
> 	PR rtl-optimization/29128
> 	* gcc.c-torture/compile/pr29128.c: New test.

> 2006-09-24  Maxim Kuvyrkov  <mkuvyrkov@ispras.ru>
> 
> 	* sched-int.h (IS_SPEC_CHECK_P, IS_SPEC_SIMPLE_CHECK_P): New macros.
> 	* sched-ebb.c (begin_schedule_ready): Use them.
> 	* haifa-sched.c (schedule_insn, move_insn, try_ready,
> 	add_to_speculative_block, create_check_block_twin, speculate_insn,
> 	fix_jump_move, move_block_after_check): Ditto.
> 	* sched-rgn.c (new_ready): Ditto.

These patches are OK if you give the macros better names and add
comments before the macro definitions.

I suggest using IS_SPECULATION_... for all three new macros.  SPEC is
not an obvious abbreviation for SPECULATION.  Be sure to explain in
the comment what you mean by BRANCHY.

Approved with those changes.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]