This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: more pthread fixincludes patch


Hi Uros,

Don't worry a lot about my time.  It is far easier to review
work than to figure out how to do it myself.  :-D

One small complaint and one nitpick, the fix looks fine
whether you address them or not:

1.  To me, it is clearer - easier to understand - if sed commands
   are separated into separate "sed" assignments.  I understand
   that the "\n" character makes for two commands, it is just
  easier (for me) to understand with additional separation.

2. Likely not worth the bother now, but for future reference:

  test_text = <<- _EOText_
       #define PTHREAD_MUTEX_INITIALIZER \
            { { 0, } }
       #ifdef __USE_GNU
       # if __WORDSIZE == 64
[[ ... ]]
      _EOText_;

makes for more readable text, too.

Thanks ! Regards, Bruce


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]